Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7.x #45

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Support Symfony 7.x #45

merged 1 commit into from
Dec 5, 2023

Conversation

pfuhrmann
Copy link
Contributor

@pfuhrmann
Copy link
Contributor Author

cc @wasinger please check

@wasinger
Copy link
Owner

wasinger commented Dec 1, 2023

Unfortunately unit tests do not pass, some method signature must have been changed in Symfony 7. @pfuhrmann could you look into this problem? Otherwise I will do it later.

@pfuhrmann
Copy link
Contributor Author

Hi @wasinger, I was not sure why the tests are not running. I just noticed you have manual approval. I can revert the workflow change if you prefer.

@pfuhrmann
Copy link
Contributor Author

@wasinger I have run the tests locally, should be all good now

@pfuhrmann
Copy link
Contributor Author

ping @wasinger

@wasinger wasinger merged commit 9fa7dfe into wasinger:master Dec 5, 2023
6 checks passed
@wasinger
Copy link
Owner

wasinger commented Dec 5, 2023

@pfuhrmann Thanks for your contribution!

@pfuhrmann pfuhrmann deleted the patch-1 branch December 9, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants